Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add jonaslagoni as maintainer #522

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

jonaslagoni
Copy link
Member

As discussed in #513 (comment) I want to help maintain the schema files from a tooling perspective 💪

As discussed in asyncapi#513 (comment) I want to help maintain the schema files from a tooling perspective 💪
CODEOWNERS Outdated Show resolved Hide resolved
@jonaslagoni jonaslagoni changed the title chore: add jonaslagoni as tooling helper chore: add jonaslagoni as maintainer Apr 17, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@smoya
Copy link
Member

smoya commented Apr 17, 2024

After merging this, @derberg will need to provide permissions to @jonaslagoni on this repo.

@derberg
Copy link
Member

derberg commented Apr 17, 2024

can't you also add @Pakisan in the same PR?

@jonaslagoni
Copy link
Member Author

Though he wanted to do it himself as well 😄

@jonaslagoni
Copy link
Member Author

He added it here: #523

@derberg
Copy link
Member

derberg commented Apr 17, 2024

ok, added you both to repo as Maintainers
merge conflict incoming in 3, 2, 1 ...

/rtm

@asyncapi-bot asyncapi-bot merged commit 8f79700 into asyncapi:master Apr 17, 2024
13 checks passed
@jonaslagoni jonaslagoni deleted the patch-4 branch April 17, 2024 20:24
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants